Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I changed the steps of the spacy model installation. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ pip install .
Before running for the first time download the related spacy model by running:

```
# !python3 -m pip install -U pip setuptools wheel
# !python3 -m pip install -U spacy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eren23 will check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think we can hold this PR for now as we spoke with @fatihsen20 about it and reached the conclusion of maybe this is a one-off case that happens under certain situations only, therefore I suggest creating issues as soon as we catch other installment problems and once we see a pattern in those we can either update installment instructions or the setup.py file to offer a solution.

# !python3 -m spacy download en_core_web_sm
```

Expand Down