Move EntityReference.IsAlive to World #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindevans
reviewed
Dec 4, 2023
| @@ -293,24 +293,7 @@ public EntityReference() | |||
| Version = -1; | |||
| } | |||
|
|
|||
| #if PURE_ECS | |||
There was a problem hiding this comment.
Could we keep this one, and just change the implementation to World.IsAlive(this)? Would be more convenient.
|
210f528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #187
IMO this is better due to the aforementioned issue as it doesn't really feel like ECS. Not sure if the preference is to Obsolete the old one or just remove it.