Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate() #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Duplicate() #241

wants to merge 1 commit into from

Conversation

nathanrw
Copy link
Contributor

@nathanrw nathanrw commented Oct 16, 2024 •
edited
Loading

I want a convenient way to duplicate entities.

At the moment you need to call GetAllComponents(), which is unsatisfying.

This implementation is faster, and could be made more efficient in future.

On my (rather old) computer (N=10000):

Method Mean Error StdDev
DuplicateNInternal 8.099 ms 0.3745 ms 1.0438 ms
DuplicateNDuplicate 8.874 ms 0.3976 ms 1.1662 ms
DuplicateNGetAllComponents 31.285 ms 0.5823 ms 0.7971 ms

@nathanrw nathanrw changed the title WIP: Duplicate Duplicate() Oct 16, 2024
@nathanrw nathanrw marked this pull request as ready for review October 16, 2024 20:59
@emelrad12
Copy link
Contributor

Just my 2 cents, but I think it would be better if you squashed as lots of the commits are WIP type.

@nathanrw
Copy link
Contributor Author

Yep. Github provides 'squash merge' does it not?

@nathanrw
Copy link
Contributor Author

I've combined the commits into one

@genaray
Copy link
Owner

genaray commented Oct 24, 2024

Gonna merge this once arch 1.3.0 is finished! Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanrw @emelrad12 @genaray