Fix tests

gencat · Nov 14, 2024 · 7db70a1 · 7db70a1
1 parent ffe90eb
commit 7db70a1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -174,7 +174,7 @@ GIT
 PATH
   remote: .
   specs:
-    decidim-challenges (0.4.1.1)
+    decidim-challenges (0.4.2)
       decidim-core (~> 0.27)
 
 GEM
@@ -270,7 +270,7 @@ GEM
       parser (>= 2.4)
       smart_properties
     bindex (0.8.1)
-    bootsnap (1.17.0)
+    bootsnap (1.18.4)
       msgpack (~> 1.2)
     browser (2.7.1)
     builder (3.2.4)
@@ -501,7 +501,7 @@ GEM
       tomlrb
     mixlib-shellout (3.2.7)
       chef-utils
-    msgpack (1.7.2)
+    msgpack (1.7.5)
     multi_xml (0.6.0)
     mustache (1.1.1)
     net-imap (0.4.9)

diff --git a/app/controllers/decidim/challenges/challenges_controller.rb b/app/controllers/decidim/challenges/challenges_controller.rb
@@ -17,7 +17,7 @@ class ChallengesController < Decidim::Challenges::ApplicationController
       helper Decidim::Sdgs::SdgsHelper
       helper Decidim::ShowFiltersHelper
 
-      helper_method :challenges, :new_solution_path
+      helper_method :challenges, :new_solution_path, :solutions_component
 
       def index
         @challenges = search.result
@@ -61,6 +61,10 @@ def new_solution_path
         component = current_participatory_space.components.find_by(manifest_name: "solutions")
         Decidim::EngineRouter.main_proxy(component).new_solution_path
       end
+
+      def solutions_component
+        current_participatory_space.components.find_by(manifest_name: "solutions")
+      end
     end
   end
 end
diff --git a/app/views/decidim/challenges/challenges/show.html.erb b/app/views/decidim/challenges/challenges/show.html.erb
@@ -13,7 +13,7 @@
               <%= link_to t('surveys.answer', scope: "decidim.challenges"), answer_challenge_survey_path(@challenge), class: "card__button button button--sc small" %>
             <% end %>
 
-            <% if current_participatory_space.components.find_by(manifest_name: "solutions").settings.creation_enabled %>
+            <% if solutions_component.settings.creation_enabled %>
               <%= action_authorized_link_to :create, new_solution_path, class: "card__button button button--sc small", data: { "redirect_url": new_solution_path } do %>
                 <%= t(".new_solution") %>
                 <%= icon "plus", role: "img", "aria-hidden": true %>

diff --git a/spec/system/decidim/challenges/challenge_new_solutions_spec.rb b/spec/system/decidim/challenges/challenge_new_solutions_spec.rb
@@ -23,15 +23,14 @@ def visit_challenge
     end
   end
 
-  context "when there are a solution component" do
-    let(:problems_component) { create(:problems_component, participatory_space: challenge.participatory_space) }
-    let!(:problem) { create :problem, component: problems_component }
+  context "when there is a solution component" do
     let(:solutions_component) { create(:solutions_component, participatory_space: challenge.participatory_space) }
     let!(:solution) { create :solution, component: solutions_component }
+    let!(:current_participatory_space) { challenge.participatory_space }
 
     before do
       solutions_component.update!(
-        creation_enabled: creation_enabled,
+        creation_enabled: true,
       )
     end