Check answer questionnaire response (#59)

gencat · Jun 7, 2022 · fe393d4 · fe393d4
1 parent 36170ed
commit fe393d4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,9 @@ Following Semantic Versioning 2.
 
 ## next version:
 
+## Version 0.0.15 (PATCH)
+- Check if the file has any errors in format in the Challenges surveys.
+
 ## Version 0.0.14 (PATCH)
 - Add missing translations in :es and :en.
 

diff --git a/app/commands/decidim/challenges/survey_challenge.rb b/app/commands/decidim/challenges/survey_challenge.rb
@@ -24,7 +24,8 @@ def call
           return broadcast(:invalid) unless can_answer_survey?
           return broadcast(:invalid_form) unless survey_form.valid?
 
-          answer_questionnaire
+          return broadcast(:invalid) if answer_questionnaire == :invalid
+
           create_survey
         end
         broadcast(:ok)
@@ -37,7 +38,15 @@ def call
       def answer_questionnaire
         return unless questionnaire?
 
-        Decidim::Forms::AnswerQuestionnaire.call(survey_form, user, challenge.questionnaire)
+        Decidim::Forms::AnswerQuestionnaire.call(survey_form, user, challenge.questionnaire) do
+          on(:ok) do
+            return :valid
+          end
+
+          on(:invalid) do
+            return :invalid
+          end
+        end
       end
 
       def create_survey

diff --git a/lib/decidim/challenges/version.rb b/lib/decidim/challenges/version.rb
@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-meetings version.
   module Challenges
     def self.version
-      "0.0.14"
+      "0.0.15"
     end
 
     def self.decidim_version