-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create solutions from public view #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create solutions in public views - Publish and unpusblish in admin - Add settings to enable or disable this feature
laurajaime
force-pushed
the
feat/create_solutions
branch
2 times, most recently
from
September 30, 2024 16:21
11a4e32
to
9c05f2e
Compare
laurajaime
force-pushed
the
feat/create_solutions
branch
from
October 1, 2024 06:49
9c05f2e
to
8d11240
Compare
laurajaime
force-pushed
the
feat/create_solutions
branch
3 times, most recently
from
October 1, 2024 08:30
3534f6b
to
a912941
Compare
laurajaime
force-pushed
the
feat/create_solutions
branch
from
October 1, 2024 09:59
a912941
to
7d62fbf
Compare
tramuntanal
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here @laurajaime 👏
I've left only some details to check
tramuntanal
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
tramuntanal
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature for create solutions by users and manage by admins.
In addition, I remove simplecov and fix test execution in CI (all workflows run all tests...)
Public
Admin