Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR for the course #83

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Draft PR for the course #83

wants to merge 2 commits into from

Conversation

sofstam
Copy link

@sofstam sofstam commented Oct 11, 2023

The purpose of the code changes are as follows:

  • I tried to run gms-artic locally both for Illumina and Nanopore data. I ran into some issues and this PR attempts to solve those.

Standard test procedure

  • The self-test mentioned in the README finished successfully
  • Produced files contain expected values
  • The code has been reviewed by @octocat

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant