Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanopore container splits #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nanopore container splits #84

wants to merge 1 commit into from

Conversation

JD2112
Copy link
Member

@JD2112 JD2112 commented Nov 8, 2023

The purpose of the code changes are as follows:

[x] nanopore container splits into nanopolish and medaka
[x] fixed issues with nanopolish, added numpy (1.21.0) and tensorflow (1.14.0)
[x] medaka version updated to 1.7.2
[x] --medaka-model added to medaka workflow.
[x] README updated
[ ] needs container updated on gms-Dockerhub.

Standard test procedure

  • The self-test mentioned in the README finished successfully
  • Produced files contain expected values
  • The code has been reviewed by @octocat

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

[x] nanopore container splits into nanopolish and medaka
[x] fixed issues with nanopolish, added numpy (1.21.0) and tensorflow (1.14.0)
[x] medaka version updated to 1.7.2
[x] --medaka-model added to medaka workflow.
[x] README updated
[ ] needs container updated on gms-Dockerhub.
Copy link
Member

@sylvinite sylvinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure looks sound.
Not test running it. So anything related to that is outside the scope of the approval.

@JD2112
Copy link
Member Author

JD2112 commented Nov 14, 2023

Structure looks sound. Not test running it. So anything related to that is outside the scope of the approval.

@sylvinite Thanks, true. I don't think it will pass the test run, since I don't know the meadka-model for the test dataset provided in nanopore data folder. Second, new docker containers need to push to gms-dockerhub. Shall I do it manually?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@sylvinite
Copy link
Member

If you need to push extra images to dockerhub, feel free to. The more the merrier ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants