Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nf-core modules #486

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Update nf-core modules #486

merged 6 commits into from
Nov 6, 2024

Conversation

fellen31
Copy link
Collaborator

@fellen31 fellen31 commented Nov 4, 2024 •
edited
Loading

Closes #310 and #476

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fellen31 fellen31 force-pushed the update-modules branch 3 times, most recently from 723cfdd to ac165c4 Compare November 4, 2024 16:24
@fellen31 fellen31 linked an issue Nov 4, 2024 that may be closed by this pull request
Update all nf-core modules before release #476
Closed
@fellen31 fellen31 force-pushed the update-modules branch 5 times, most recently from 1ddbe44 to c903970 Compare November 6, 2024 07:54
@fellen31 fellen31 marked this pull request as ready for review November 6, 2024 09:33
@fellen31 fellen31 requested a review from a team as a code owner November 6, 2024 09:33
jemten
jemten approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fellen31 fellen31 merged commit 73cca58 into genomic-medicine-sweden:dev Nov 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemten jemten jemten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Nallo
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all nf-core modules before release Update MultiQC to 1.23 and check that all files exists in test
2 participants
@fellen31 @jemten