Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing changelog items #490

Merged
merged 1 commit into from
Nov 6, 2024
Merged

missing changelog items #490

merged 1 commit into from
Nov 6, 2024

Conversation

fellen31
Copy link
Collaborator

@fellen31 fellen31 commented Nov 6, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fellen31 fellen31 marked this pull request as ready for review November 6, 2024 13:00
@fellen31 fellen31 requested a review from a team as a code owner November 6, 2024 13:00
Lucpen
Lucpen approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Lucpen Lucpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fellen31 fellen31 merged commit d023a57 into genomic-medicine-sweden:dev Nov 6, 2024
22 checks passed
@fellen31 fellen31 deleted the missing-changelog-entries branch November 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucpen Lucpen Lucpen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Nallo
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fellen31 @Lucpen