Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #206

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Update README.md #206

merged 6 commits into from
Dec 7, 2023

Conversation

houjun
Copy link
Collaborator

@houjun houjun commented Dec 6, 2023

Add citation

@houjun houjun requested a review from andersp December 6, 2023 21:51
@andersp
Copy link
Contributor

andersp commented Dec 6, 2023

Can you please put the user's guide in its own category. Also order the papers in reversed chronological order, i.e., with the (2021) at the top. Otherwise it looks very good.

@houjun
Copy link
Collaborator Author

houjun commented Dec 6, 2023

done.

@andersp
Copy link
Contributor

andersp commented Dec 6, 2023

The report number is listed twice in the user's guide reference, i.e., "LLNL-SM-741439 (LLNL-SM-741439)". Once would be enough. Thanks

@andersp
Copy link
Contributor

andersp commented Dec 6, 2023

Looks good. I will merge once the tests have passed.

@andersp andersp merged commit 03cb7e8 into master Dec 7, 2023
2 checks passed
@houjun houjun deleted the houjun-patch-1 branch September 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants