Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GUI based on data format updates #65

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

brianlove
Copy link
Contributor

Adjust the PARAT v2 GUI to work with the data updates in #41

Split the cells 60/40 for raw number vs rank
Add new data types to the charts on the detail pages.
@brianlove brianlove requested a review from jmelot August 28, 2023 18:24
@brianlove brianlove self-assigned this Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

No need for rebasing 👍
behind_count is 0
ahead_count is 5

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 65%
64.19% (199/310) 50.83% (61/120) 70.75% (75/106)
Modified Files • (65%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files64.1950.8370.7565.06 
components71.4958.0675.6772.01 
   CellStat.jsx100100100100 
   DetailViewPatents.jsx0100008–62
   DetailViewPublications.jsx0100007–42
   ListViewTable.jsx88.6368.4992.390.32146–147, 173–174, 179–186, 234, 257, 337–342
pages0000 
   company-detail.js000012–37
static_data87.510010087.5 
   table_columns.js100100100100 
util65.941.1766.6666.66 
   plotly-helpers.js00005–40

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good for now... and it's reminding me I need to add rank back in.

@jmelot jmelot merged commit 7a50a39 into 8-update-data-retrieval Aug 29, 2023
4 checks passed
@jmelot jmelot deleted the bjl-adapt-gui-for-new-data branch August 29, 2023 15:05
@brianlove
Copy link
Contributor Author

@jmelot Are you planning on adding rank within #41, or will that be a later addition?

@jmelot
Copy link
Member

jmelot commented Aug 29, 2023

Yeah I'll add it to #41... I thought I did it already but apparently forgot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants