Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gcpy/benchmark/modules/species_database.yml #333

Closed
yantosca opened this issue Aug 14, 2024 · 1 comment · Fixed by #339
Closed

Remove gcpy/benchmark/modules/species_database.yml #333

yantosca opened this issue Aug 14, 2024 · 1 comment · Fixed by #339
Assignees
@yantosca
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)
Milestone
1.6.0

Comments

@yantosca
Copy link
Contributor

Your name

Bob Yantosca

Your affiliation

Harvard + GCST

Provide a clear and concise overview of the new feature requested.

There is an outdated copy of the GEOS-Chem species database file at gcpy/benchmark/modules/species_database.yml. I would propose to remove this, as the benchmarking scripts now allow you to specify the directory path to species_database.yml. If you list this path as default, GCPy will use the path to the Dev benchmark folder.

Tagging @msulprizio @lizziel

Will you be implementing this feature yourself?

Yes

Additional information

No response
@yantosca yantosca added category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates) labels Aug 14, 2024
@yantosca yantosca self-assigned this Aug 14, 2024
@yantosca yantosca added this to the 1.6.0 milestone Sep 12, 2024
@yantosca yantosca mentioned this issue Sep 12, 2024
Merged
@yantosca yantosca linked a pull request Sep 12, 2024 that will close this issue
Remove the default gcpy/benchmark/modules/species_database.yml file #339
Merged
@yantosca
Copy link
Contributor Author

We can now close this as PR #339 has been merged into the GCPy 1.6.0 development stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Structural Modifications Related to GCPy structural modifications (as opposed to scientific updates)
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Remove the default gcpy/benchmark/modules/species_database.yml file geoschem/gcpy
1 participant
@yantosca