Remove the default gcpy/benchmark/modules/species_database.yml file #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/benchmark/modules/species_database.yml - Removed. This file was substantially out-of-date with GEOS-Chem. We now specify the path to this file in the YAML configuration files that are passed to gcpy/benchmark/run_benchmark.py, so this is now redundant. gcpy/benchmark/modules/benchmark_drydep.py gcpy/benchmark/modules/benchmark_funcs.py gcpy/benchmark/modules/benchmark_mass_cons_table.py gcpy/benchmark/modules/budget_ox.py gcpy/benchmark/modules/budget_tt.py gcpy/benchmark/modules/oh_metrics.py - Replaced spcdb_dir=os.path.dirname(__file__) with spcdb_dir=None in function interfaces - Add code to throw a ValueError if spcdb_dir is None CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
category: Feature Request
yantosca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This is the companion PR to #333. We have removed the
gcpy/benchmark/modules/species_database.ymlfile, which formerly was used by the benchmarking code in case thespecies_database.ymlfile was not found in the Dev run directory. This file by now is seriously out of date w/r/t thespecies_database.ymlin GEOS-Chem, so it is better not to rely on it.The benchmarking scripts now allow you to specify a path to the species database file in the YAML config files (e.g.
1mo_benchmark.yml,1yr_fullchem_benchmark.yml, etc). So relying on a defaultspecies_database.ymlfile is no longer necessary.In several benchmarking routines (in
gcpy/benchmark/modules/), thespcdb_dir(path to the folder containingspecies_database.yml) argument is now set toNoneby default. Error checks then will raise aValueErrorif thespcdb_dirisNoneand notstr. This will gracefully terminate program execution.Expected changes
This is a zero-diff update.
Reference(s)
If this is a science update, please provide a literature citation.
Related Github Issue