Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tomcat version in POM files #10620

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Fixing tomcat version in POM files #10620

merged 4 commits into from
Oct 21, 2024

Conversation

tdipisa
Copy link
Member

@tdipisa tdipisa commented Oct 18, 2024

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa tdipisa marked this pull request as draft October 18, 2024 16:19
@tdipisa tdipisa added this to the 2025.01.00 milestone Oct 18, 2024
@tdipisa tdipisa self-assigned this Oct 18, 2024
@tdipisa tdipisa marked this pull request as ready for review October 18, 2024 16:21
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aligned the version of tomcat used in dev env with the variable.
I tested and it seems to work well.

@offtherailz offtherailz merged commit 3e5eefd into master Oct 21, 2024
6 checks passed
@tdipisa tdipisa deleted the tdipisa-patch-3 branch October 21, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants