Fix #10626 adding possibilities for better updating store #10627
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # web/client/actions/__tests__/catalog-test.js
MV88
commented
Oct 24, 2024
web/client/actions/layers.js
Outdated
| */ | ||
| export function updateAllLayers(layers) { | ||
| return { | ||
| type: UPDATE_ALL_LAYERS, |
There was a problem hiding this comment.
Based also on the jsdoc this operation represent a replacement so I would call this REPLACE_LAYERS/replaceLayers
MV88
changed the title
allyoucanmap
approved these changes
Oct 25, 2024
|
@MV88 @ElenaGallo this improvements are related to new actions for development so I don't think there are test to be done |
correct |
MV88
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10626
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information