Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9254 Add parametric image parsing to template viewer #9260

Merged
merged 13 commits into from
Jul 5, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Jun 28, 2023

Description

Added possibility to insert image url in markdown

image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#9254

What is the new behavior?

  • You can now use markdown syntax in the template editor
  • there is a specific button that wraps the text selected into image syntax
  • removed react-quill from FeatureInfoEditor in favor of react-draft-wysiwyg
  • fixed also style for description editor in map views since that style was creating issues and were not needed,
  • maybe we can discuss if we want the min-height to 200 in feature info editor or not

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa if we add a layer in gs-stable this would be easier for the tester
image

@MV88 MV88 added New Feature used for new functionalities C265-ATOLCD-2023-DEV_MS_CNR labels Jun 28, 2023
@MV88 MV88 added this to the 2023.02.00 milestone Jun 28, 2023
@MV88 MV88 requested a review from offtherailz June 28, 2023 14:31
@MV88 MV88 self-assigned this Jun 28, 2023
@tdipisa tdipisa linked an issue Jun 28, 2023 that may be closed by this pull request
5 tasks
@offtherailz
Copy link
Member

offtherailz commented Jun 30, 2023

From our meeting with @MV88 to provide this functionality, I suggested to use the current image tool, improving it at least, instead of introducing the support to markdown inside wyiswyg that may be a problem for future maintainance of the functionality.
I love markdown and if we are going to introduce it I should do it as a complete alternative syntax.
I'd like to see with you too @allyoucanmap to have your opinion, next week.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove the mixed markdown support and so the new image tool. Use the image tool present in react wysiwyg (replacing react quill)
  • Check for backward compatibility with existing templates created with react quill ( I tried and it seems to work on demo map)

@MV88 MV88 requested a review from offtherailz July 3, 2023 14:15
@MV88
Copy link
Contributor Author

MV88 commented Jul 3, 2023

  • Please remove the mixed markdown support and so the new image tool. Use the image tool present in react wysiwyg (replacing react quill)
  • Check for backward compatibility with existing templates created with react quill ( I tried and it seems to work on demo map)

done both @offtherailz please review it again

web/client/translations/data.de-DE.json Outdated Show resolved Hide resolved
web/client/translations/data.en-US.json Outdated Show resolved Hide resolved
web/client/translations/data.es-ES.json Outdated Show resolved Hide resolved
web/client/translations/data.fr-FR.json Outdated Show resolved Hide resolved
web/client/translations/data.it-IT.json Outdated Show resolved Hide resolved
@MV88 MV88 requested a review from offtherailz July 5, 2023 09:31
@offtherailz offtherailz enabled auto-merge (squash) July 5, 2023 10:07
@offtherailz offtherailz merged commit 3c0e7ac into geosolutions-it:master Jul 5, 2023
@MV88
Copy link
Contributor Author

MV88 commented Jul 5, 2023

@ElenaGallo please test it in DEV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C265-ATOLCD-2023-DEV_MS_CNR New Feature used for new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parametric image parsing to template viewer
2 participants