Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Switch to gojsonschema #318

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Signed-off-by: Pierre Fenoll <[email protected]>
Signed-off-by: Pierre Fenoll <[email protected]>
Signed-off-by: Pierre Fenoll <[email protected]>
@bhechinger
Copy link

What is holding this PR back? I really need kin-openapi to properly validate nullable enums. :(

@fenollp
Copy link
Collaborator Author

fenollp commented Jul 6, 2021

@bhechinger From #230 we most probably will move to use https://github.com/qri-io/jsonschema instead of the lib in this PR.

I didn't start work on this yet.. maybe give it a shot?

@bhechinger
Copy link

@fenollp I'll take a look. If it's not going to be too much work to get done I may actually be able to make it a pre-req for my current task at work. :)

@bhechinger
Copy link

Due to our current timeline crunch I won't have time for this right now. However, I was instructed to open a tech debt ticket to track this and come back to it later. If this hasn't been done by someone else in the next several months I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants