Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slash removing in documentPathForRecursiveRef method #478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bozaro
Copy link

@bozaro bozaro commented Jan 21, 2022

Unfortunately path.Join remove last slash from result file.

For example:

path.Join("foo/bar/", "") == "foo/bar"

As result documentPathForRecursiveRef(current, "") returns rootDir without directory as file path and next relative path resolving lost last rootDir element.

In this workaround I try to restore last slash if needed.

@fenollp fenollp self-requested a review January 22, 2022 15:01
Copy link
Collaborator

@fenollp fenollp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants