Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ordered maps #695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use ordered maps #695

wants to merge 2 commits into from

Conversation

fenollp
Copy link
Collaborator

@fenollp fenollp commented Dec 4, 2022

Fixes #645

@fenollp fenollp changed the title WIP needs un/marshalling Use ordered maps Dec 4, 2022
openapi3/loader.go Fixed Show fixed Hide fixed
openapi3/loader.go Fixed Show fixed Hide fixed
@fenollp fenollp force-pushed the issue645 branch 3 times, most recently from 391b9a7 to 1afb638 Compare December 19, 2022 16:59
@bitomaxsp
Copy link

bitomaxsp commented Dec 20, 2022

What kind of help is needed here? We (@northvolt) are super eager to see that released :)

@fenollp
Copy link
Collaborator Author

fenollp commented Dec 20, 2022

Hey @bitomaxsp I'd love some help! Right now I'm stuck solving this:

FAIL | Issue301 (0.00s)
     | panic: runtime error: invalid memory address or nil pointer dereference [recovered]
     | 	panic: runtime error: invalid memory address or nil pointer dereference
     | [signal SIGSEGV: segmentation violation code=0x1 addr=0x58 pc=0x805850]
     | goroutine 19 [running]:
     | testing.tRunner.func1.2({0x888260, 0xc6abe0})
     | 	/snap/go/10008/src/testing/testing.go:1396 +0x24e
     | testing.tRunner.func1()
     | 	/snap/go/10008/src/testing/testing.go:1399 +0x39f
     | panic({0x888260, 0xc6abe0})
     | 	/snap/go/10008/src/runtime/panic.go:884 +0x212
     | github.com/getkin/kin-openapi/openapi3.TestIssue301(0x0?)
     | 	/home/pete/wefwefwef/kin-openapi.git/openapi3/issue301_test.go:32 +0x250
     | testing.tRunner(0xc0001ac820, 0x947b40)
     | 	/snap/go/10008/src/testing/testing.go:1446 +0x10b
     | created by testing.(*T).Run
     | 	/snap/go/10008/src/testing/testing.go:1493 +0x35f
FAIL | 	github.com/getkin/kin-openapi/openapi3	0.005s

From there I believe the design satisfies me. The rest of the work should be straightforward(TM)!

Could you describe your needs WRT this patch a bit?

Signed-off-by: Pierre Fenoll <[email protected]>
Signed-off-by: Pierre Fenoll <[email protected]>
@takanuva15
Copy link

Hi, did you have any luck fixing this issue? Looks like I encountered the same circular reference problem when trying to use this library with a large complex schema like in #814

@renom
Copy link

renom commented Aug 9, 2024

Is it going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please user OrderedMap instead of the golang's map
4 participants