fixed trigger out of bounds panic, test all strategies w/ pcap file (file not included) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hector-Lantern, you should be able to use this branch inplace of |
Crosse
reviewed
Mar 1, 2024
| } | ||
| } | ||
|
|
||
| func TestApplyAllStrategies(t *testing.T) { |
There was a problem hiding this comment.
If we're not going to ship internal/testdata/input.pcap (and it makes sense to me why we're not right now), what do you think about adding t.Skip("no input.pcap file") at the head of this test so that it doesn't interfere with anyone running the tests after an initial clone?
There was a problem hiding this comment.
Good point. Adding it.
Pull Request Test Coverage Report for Build 8118626690Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to run
TestApplyAllStrategiesa pcap file must be added tointernal/testdata/input.pcap. I didn't want to include the one I had as Hector sent it to me and I wasn't sure if it had sensitive information in it.