test/preprocessors: return promises (#1286)

These tests were always passing because their assertions were contained in unreturned promises.
getodk · Nov 13, 2024 · ca1652e · ca1652e
1 parent 695fa2c
commit ca1652e
Showing 1 changed file with 4 additions and 18 deletions.
diff --git a/test/unit/http/preprocessors.js b/test/unit/http/preprocessors.js
@@ -183,8 +183,7 @@ describe('preprocessors', () => {
           should.not.exist(context);
         }));
 
-      it('should prioritise primary auth over Cookie auth', () => {
-        let caught = false;
+      it('should prioritise primary auth over Cookie auth', () =>
         Promise.resolve(authHandler(
           { Auth, Sessions: mockSessions('alohomora') },
           new Context(
@@ -196,16 +195,9 @@ describe('preprocessors', () => {
             }, cookies: { session: 'alohomora' } }),
             { auth: { isAuthenticated() { return false; } }, fieldKey: Option.none() }
           )
-        )).catch((err) => {
-          err.problemCode.should.equal(401.2);
-          caught = true;
-        }).then(() => {
-          caught.should.equal(true);
-        });
-      });
+        )).should.be.rejectedWith(Problem, { problemCode: 401.2 }));
 
-      it('should prioritise fk auth over Cookie auth', () => {
-        let caught = false;
+      it('should prioritise fk auth over Cookie auth', () =>
         Promise.resolve(authHandler(
           { Auth, Sessions: mockSessions('alohomora') },
           new Context(
@@ -222,13 +214,7 @@ describe('preprocessors', () => {
             }),
             { auth: { isAuthenticated() { return false; } }, fieldKey: Option.none() }
           )
-        )).catch((err) => {
-          err.problemCode.should.equal(401.2);
-          caught = true;
-        }).then(() => {
-          caught.should.equal(true);
-        });
-      });
+        )).should.be.rejectedWith(Problem, { problemCode: 401.2 }));
 
       it('should work for HTTPS GET requests', () =>
         Promise.resolve(authHandler(