Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include entity create 2022.1 forms in 2024.1 upgrade #1253

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Oct 29, 2024

Closes getodk/central#757

  • adds a new migration that flags all the other entity forms in the table dataset_form_defs (forms that reference datasets but don't update)
  • adds form migration code that can transform a v2022.1 form into a v2024.1 form by changing the entity spec version and adding a suffix to the form version
    • every flagged form is upgraded to the 2024.1 version by trying both 2022 and 2023 upgrades (which have no effect if the specific old version is not found)

I could have gone back and changed the existing migration, but since this has already been applied on the QA server, it seemed ok to just add another migration.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite merged commit 1090748 into master Oct 29, 2024
7 checks passed
@ktuite ktuite deleted the ktuite/migrate-entity-create-forms branch October 29, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate entity-creating forms to 2024.1.0 entities spec
2 participants