-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pelican decouple build workflow #3404
Open
noelmiller
wants to merge
8
commits into
getpelican:main
Choose a base branch
from
noelmiller:pelican_decouple_build_workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pelican decouple build workflow #3404
noelmiller
wants to merge
8
commits into
getpelican:main
from
noelmiller:pelican_decouple_build_workflow
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ca672f - Browse repository at this point
Copy the full SHA 5ca672fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 403d507 - Browse repository at this point
Copy the full SHA 403d507View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84e31ba - Browse repository at this point
Copy the full SHA 84e31baView commit details
Commits on Oct 14, 2024
-
Combine
build.yml
andgithub_pages.yml
Combine `build.yml` and `github_pages.yml` into a single workflow file. Having `build.yml` be a separate workflow file that `github_pages.yml` calls has two problems: 1. All the inputs (and their types, descriptions, defaults) have to be duplicated in the two workflow files. 2. The reference to `@main` in `uses: "getpelican/pelican/.github/workflows/build.yml@main"` in the `github_pages.yml` workflow makes development and testing awkward. For example let's say you want to send a pull request that contains changes to `build.yml` and that also requires changes to `github_pages.yml` at the same time. The problem is that the `github_pages.yml` on your PR branch will still contain the reference to `build.yml` `@main` so if you try to test the branch's version of `github_pages.yml` it'll call the version of `build.yml` from `main` not from the PR branch and will fail. This commit move the build job from `build.yml` into `github_pages.yml` but makes the deploy job optional: it adds a `deploy` input and will only run the deploy job if `deploy = true` is passed. Previously a user could test their build without deploying it by calling the separate `build.yml` workflow. Now they can do it by calling the `github_pages.yml` workflow and passing `deploy=false`. This commit also moves the `concurrency` stuff from the workflow level to the deploy level: it's okay to have multiple build jobs running concurrently, just not multiple deploy jobs.
Configuration menu - View commit details
-
Copy full SHA for f9a0d9e - Browse repository at this point
Copy the full SHA f9a0d9eView commit details
Commits on Oct 17, 2024
-
Merge pull request #1 from seanh/pelican_decouple_build_workflow-sing…
…le-file Combine `build.yml` and `github_pages.yml`
Configuration menu - View commit details
-
Copy full SHA for ab07896 - Browse repository at this point
Copy the full SHA ab07896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7304fe5 - Browse repository at this point
Copy the full SHA 7304fe5View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fdbf97a - Browse repository at this point
Copy the full SHA fdbf97aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f033bac - Browse repository at this point
Copy the full SHA f033bacView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.