Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pelican decouple build workflow #3404

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Oct 8, 2024

  1. create build.yml

    noelmiller committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5ca672f View commit details
    Browse the repository at this point in the history
  2. update github_pages.yml

    noelmiller committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    403d507 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84e31ba View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Combine build.yml and github_pages.yml

    Combine `build.yml` and `github_pages.yml` into a single workflow file.
    Having `build.yml` be a separate workflow file that `github_pages.yml`
    calls has two problems:
    
    1. All the inputs (and their types, descriptions, defaults) have to be
       duplicated in the two workflow files.
    
    2. The reference to `@main` in `uses: "getpelican/pelican/.github/workflows/build.yml@main"`
       in the `github_pages.yml` workflow makes development and testing
       awkward.
    
    For example let's say you want to send a pull request that contains
    changes to `build.yml` and that also requires changes to
    `github_pages.yml` at the same time. The problem is that the
    `github_pages.yml` on your PR branch will still contain the reference to
    `build.yml` `@main` so if you try to test the branch's version of
    `github_pages.yml` it'll call the version of `build.yml` from `main` not
    from the PR branch and will fail.
    
    This commit move the build job from `build.yml` into `github_pages.yml`
    but makes the deploy job optional: it adds a `deploy` input and will
    only run the deploy job if `deploy = true` is passed.
    
    Previously a user could test their build without deploying it by calling
    the separate `build.yml` workflow. Now they can do it by calling the
    `github_pages.yml` workflow and passing `deploy=false`.
    
    This commit also moves the `concurrency` stuff from the workflow level
    to the deploy level: it's okay to have multiple build jobs running
    concurrently, just not multiple deploy jobs.
    seanh committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f9a0d9e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge pull request #1 from seanh/pelican_decouple_build_workflow-sing…

    …le-file
    
    Combine `build.yml` and `github_pages.yml`
    noelmiller authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ab07896 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7304fe5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    fdbf97a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f033bac View commit details
    Browse the repository at this point in the history