ref: Use the VM to execute local config files #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scttcper
approved these changes
Sep 25, 2024
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-use-the-vm-to-execute-local-config-files
branch
from
a4c4d1e
to
c07dbc8
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-use-the-vm-to-execute-local-config-files
branch
from
c07dbc8
to
8847926
Compare
|
formatting gdi lol |
This makes config file loading consistent between using the http config resolver and passing a local file path to load the config. Consistency is important here for us since in Sentry we have chartucterie acceptance tests, which are there to help us catch changes made to Sentry's javascript app that may break chartucterie. However they are run with chartucterie having loaded the config using a file path and not HTTP, which differs from happens in production, where we resolve the config via HTTP and execute it in a vm context. By making these consistent we catch errors that happen loading the config in the vm contextchartucterie VM.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-use-the-vm-to-execute-local-config-files
branch
from
8847926
to
cef485e
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-use-the-vm-to-execute-local-config-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes config file loading consistent between using the http config resolver and passing a local file path to load the config.
Consistency is important here for us since in Sentry we have chartucterie acceptance tests, which are there to help us catch changes made to Sentry's javascript app that may break chartucterie. However they are run with chartucterie having loaded the config using a file path and not HTTP, which differs from happens in production, where we resolve the config via HTTP and execute it in a vm context.
By making these consistent we catch errors that happen loading the config in the vm contextchartucterie VM.