fix(github): Increase artifact polling interval and max retries #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
approved these changes
Aug 3, 2023
|
Looks like you need to update the test snapshots now: yarn test -u |
lforst
approved these changes
Aug 3, 2023
|
Hmm I don't know why the pr-check job is failing. Anyone have an idea why/how to fix? |
Comment on lines
2
to
8
| import { getGitHubClient } from '../../utils/githubApi'; | ||
| import { | ||
| GitHubArtifactProvider, | ||
| ArtifactItem, | ||
| lazyRequest, | ||
| lazyRequestCallback, | ||
| } from '../github'; |
There was a problem hiding this comment.
the reformat makes it really difficult to see what changed here -- can you discard those changes?
can probably set up formatting separately
|
I'd love to 🚢 but I can't merge as long as the |
asottile-sentry
force-pushed
the
lms/increase-artifact-retries
branch
from
aa97da6
to
7fa73cc
Compare
|
I killed cloudbuild so this should be better now |
|
Closing due to #482 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #482 by @BYK we should increase the time we wait for the build artifacts so that the publishing process doesn't fail if GH didn't upload artifacts within 30s.
closes #482