Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

ref: Simplify travis setup #1303

Merged
merged 4 commits into from
Sep 28, 2018
Merged

ref: Simplify travis setup #1303

merged 4 commits into from
Sep 28, 2018

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Sep 25, 2018 •
edited
Loading

Fix #1275

ashwoods
ashwoods reviewed Sep 27, 2018
View reviewed changes
Copy link
Contributor

@ashwoods ashwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. The extra linters were never in travis.
The goal of the many envs was to:

  • run faster (parallel builds)
  • fail sooner (The builds often just get stuck, and restarting a single env is faster)
    Tradeoffs, take your pick.

@untitaker
Copy link
Member Author

@ashwoods yeah speed is quite the issue. If this becomes too much of a pain we should look into autogenerating .travis.yml from tox.ini. The previous situation was that some things were claimed to be tested in tox but never actually run in travis.

@untitaker untitaker merged commit 7ecc5a8 into master Sep 28, 2018
@untitaker untitaker deleted the ref/ci-setup branch September 28, 2018 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwoods ashwoods ashwoods left review comments

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @ashwoods