Fix(Capacitor): Expand configure setup to other frameworks #11255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 52.82kB (0.38%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
kahest
reviewed
Sep 6, 2024
platform-includes/getting-started-config/javascript.capacitor.mdx
Outdated
Show resolved
Hide resolved
vivianyentran
approved these changes
Sep 6, 2024
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
lucas-zimerman
changed the title
kahest
approved these changes
Oct 14, 2024
platform-includes/getting-started-config/javascript.capacitor.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Karl Heinz Struggl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
This PR will give the correct snippet for the latest angular and the old version, but also adds the React and Vui snippet that were missing and with that, removed the
others frameworksnippet since we are covering all the frameworks with it.Close #11085
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES