Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Added new option http_methods_to_capture to Flask and Django docs. #11348

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Sep 13, 2024

DESCRIBE YOUR PR

This is part of this PR:
getsentry/sentry-python#3528

This should not be merged until the feature has been released.

Preview:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Oct 1, 2024 0:31am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 0:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 0:31am

Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.01kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

docs/platforms/python/integrations/django/index.mdx Outdated Show resolved Hide resolved
docs/platforms/python/integrations/flask/index.mdx Outdated Show resolved Hide resolved
@antonpirker antonpirker merged commit 9b49e31 into master Oct 1, 2024
9 of 10 checks passed
@antonpirker antonpirker deleted the antonpirker/python/http_methods_to_capture branch October 1, 2024 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants