Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop Docs] Clean up "SDK Development" Sidebar #11542

Merged
merged 17 commits into from
Oct 14, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 10, 2024

DESCRIBE YOUR PR

Organize the content in the "SDK Development" section of the develop docs better.

Preview: https://develop-docs-git-antonpirker-developsdk-sidebar.sentry.dev/getting-started/

Todos:

  • Fix links in all the pages moved
  • Add redirects from old to new location of pages

Screenshot 2024-10-14 at 10 22 22

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:55am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:55am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:55am

@bruno-garcia
Copy link
Member

looking just at the screenshot on the description: looks like a great improvement. Thanks Anton!

@stephanie-anderson
Copy link
Contributor

Looks amazing Anton, thank you!

@sentrivana
Copy link
Contributor

Looking great, thanks for cleaning this up!

@philipphofmann
Copy link
Member

This makes sense to me. Thanks @antonpirker 👍

Copy link

codecov bot commented Oct 11, 2024

Bundle Report

Changes will increase total bundle size by 2.66kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 2.66kB (0.04%) ⬆️
sentry-docs-edge-server-array-push 257.08kB 8 bytes (0.0%) ⬆️
sentry-docs-client-array-push 6.43MB 6 bytes (-0.0%) ⬇️

@antonpirker antonpirker removed the wip label Oct 14, 2024
@antonpirker antonpirker marked this pull request as ready for review October 14, 2024 08:48
@antonpirker antonpirker changed the title [WIP] Clean up "SDK Development" Sidebar [Develop Docs] Clean up "SDK Development" Sidebar Oct 14, 2024
@antonpirker antonpirker enabled auto-merge (squash) October 14, 2024 08:51
@antonpirker
Copy link
Member Author

Because almost no text was changed (only pages where moved around to have better structure of the information) I will merge this without docs team reviewing it.

@antonpirker antonpirker merged commit 747f4e8 into master Oct 14, 2024
12 checks passed
@antonpirker antonpirker deleted the antonpirker/develop/sdk-sidebar branch October 14, 2024 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants