Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js): Add skipBrowserExtensionCheck documentation #11693

Merged
merged 4 commits into from
Nov 7, 2024
Merged

feat(js): Add skipBrowserExtensionCheck documentation #11693

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
623df22
feat(js): Add `skipBrowserExtensionCheck` documentation
Lms24 Oct 31, 2024
273c148
continue example :D
Lms24 Oct 31, 2024
c9db406
Update docs/platforms/javascript/common/best-practices/shared-environ…
Lms24 Nov 4, 2024
ce6b381
Apply suggestions from code review
Lms24 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/platforms/javascript/common/best-practices/shared-environments.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,4 @@ You'd risk quota increases with unactionable issues, interference with other Sen
</Alert>

This option is purely meant as an escape hatch if our browser extension check is incorrectly detecting a browser extension.
An example for this might be a
An example for this might be a cross-platform application framework that exposes similar global APIs like browser a browser extension environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is off here or am I missing something? 🤔
"like browser a browser extension"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof you're right, fixed it now hopefully :)

Lms24 marked this conversation as resolved.
Show resolved Hide resolved
Loading