addworker notification for preventing goroutines leak #894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, came across the fact that many of our applications have started to notice goroutine leaks. Found out that
the reason is that we initialize the
HTTPSyncTransport
object many times in so-calledhandlers
:goroutine t.worker leaks in our case.
Using blocking
HTTPSyncTransport
is not beneficial for us and spoils latency.You can take a look at the solution, thanks to which we managed to reduce the number of running goroutines by orders of magnitude!
Seems like it could be a solution for 731 issue
Thanks for your product anyway.