build(release): Add statusProvider context check for craft
#8685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure we wait for the correct check to pass before continuing with publishing.
Lms24
approved these changes
Aug 1, 2023
Lms24
added a commit
that referenced
this pull request
Aug 3, 2023
…8685) (#8729) Seems like the `context` passed isn't found which is blocking our release. Reverting for now until we know how to configure the status provider correctly (getsentry/craft#482). #uncraft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we wait for the correct check to pass before continuing with publishing.
I think it is correct to use the "human readable" name of the check (??), at least the example looks similar. This is an example for what we are waiting for: https://github.com/getsentry/sentry-javascript/actions/runs/5715683859/job/15486522728
If I understand this correctly, this was completely broken and just looked for any (??) successful check..?!
See getsentry/craft#482