-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Add a default cURL HTTP client #1589
Conversation
e955aae
to
b5b81a6
Compare
Fix PHP 7.2 - 7.3 tests Fix CS Remove .relay folder
b5b81a6
to
fa5145d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I've already said in #1586 (comment), I'm against writing our own HTTP client but, since I recognize I don't have a final say in this, I'm still giving my review.
I would at least suggest leveraging PSR-18 (HTTP client) and so PSR-7 (request/response) with it, but we could ditch PSR-17 (factories) to keep it simple.
I agree with everything already said by @Jean85: first of all, I don’t understand the reason to have our own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal this is starting to look great, mostly because it's a heck of a lot simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🚀
Merging now to unblock other features. The remaining ToDos are documented in #1595 |
Work in Progress
This adds a cURL-based HTTP client and simplifies the setup when using a custom
Transport
orHttpClient
.As mentioned in #1586, this removes the
/store
endpoint entirely. All events are now sent to the/envelope
endpoint.