Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only skip real exceptions #1781

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Only skip real exceptions #1781

wants to merge 2 commits into from

Conversation

wjzijderveld
Copy link

When adding a exception property to the monolog context, it would get skipped regardless if the exception was used as hint or not.

cleptric
cleptric reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something for the next major. Not keen of changing this behavior in a minor.

@wjzijderveld
Copy link
Author

I can understand that, in a weird way it's a BC break.
Personally consider it a bugfix, as PSR-3 states that the context can contain anything and would need to be verified if it's actually an Exception as it can be anything. And currently this data is completely dropped when send to Sentry, which is super confusing.

@cleptric cleptric marked this pull request as draft November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjzijderveld @cleptric