misc: Update to RN 0.73.9, fix CI flipper error #3981

krystofwoldrich · 2024-07-30T15:05:59Z

📢 Type of change

Bugfix

📜 Description

This PR fixes the failing CI builds.

iOS development builds were failing due to Flipper and latest Xcode incompatibility.

This PR updates to the latest RN 0.73 and disables Flipper for all iOS CI builds. (Android is not that easy to disabled, but luckily doesn't cause issues)

We can't upgrade to 0.74 yet due to #3980

💚 How did you test it?

sample, CI

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

#skip-changelog

github-actions · 2024-07-30T15:19:35Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	438.08 ms	458.84 ms	20.76 ms
Size	17.73 MiB	20.05 MiB	2.31 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c398f67`	449.64 ms	461.38 ms	11.74 ms
`d7401ac`+dirty	375.20 ms	383.51 ms	8.31 ms
`12427f4`	393.69 ms	414.84 ms	21.14 ms
`4cc5c27`	460.04 ms	496.32 ms	36.28 ms
`31fcca2`	391.22 ms	414.78 ms	23.56 ms
`abb7058`	370.27 ms	389.58 ms	19.31 ms
`e2b64fe`	316.88 ms	330.23 ms	13.35 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms

App size

Revision	Plain	With Sentry	Diff
`c398f67`	17.73 MiB	19.94 MiB	2.21 MiB
`d7401ac`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`12427f4`	17.73 MiB	19.85 MiB	2.12 MiB
`4cc5c27`	17.73 MiB	19.95 MiB	2.21 MiB
`31fcca2`	17.73 MiB	19.90 MiB	2.17 MiB
`abb7058`	17.73 MiB	19.83 MiB	2.10 MiB
`e2b64fe`	17.73 MiB	19.80 MiB	2.07 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB

github-actions · 2024-07-30T15:50:53Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1211.96 ms	1213.41 ms	1.45 ms
Size	2.36 MiB	3.06 MiB	717.53 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`4a6664f`+dirty	1209.49 ms	1208.63 ms	-0.86 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`f06c879`+dirty	1252.64 ms	1259.66 ms	7.02 ms
`5a22220`+dirty	1209.49 ms	1220.94 ms	11.45 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms

App size

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`4a6664f`+dirty	2.36 MiB	3.04 MiB	696.39 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`f06c879`+dirty	2.36 MiB	2.88 MiB	530.42 KiB
`5a22220`+dirty	2.36 MiB	2.92 MiB	570.21 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB

github-actions · 2024-07-30T16:01:59Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	403.98 ms	456.48 ms	52.50 ms
Size	7.15 MiB	8.32 MiB	1.17 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`12427f4`+dirty	379.48 ms	400.92 ms	21.44 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms
`4a6664f`+dirty	357.02 ms	394.91 ms	37.89 ms
`c398f67`+dirty	315.08 ms	345.60 ms	30.52 ms
`1d86dd6`+dirty	335.76 ms	371.22 ms	35.46 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`9433f35`+dirty	265.50 ms	336.08 ms	70.58 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms

App size

Revision	Plain	With Sentry	Diff
`12427f4`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB
`4a6664f`+dirty	7.15 MiB	8.22 MiB	1.07 MiB
`c398f67`+dirty	7.15 MiB	8.21 MiB	1.07 MiB
`1d86dd6`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`9433f35`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB

github-actions · 2024-07-30T16:04:52Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1229.02 ms	1234.30 ms	5.28 ms
Size	2.92 MiB	3.62 MiB	718.55 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`4a6664f`+dirty	1218.77 ms	1221.07 ms	2.30 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`dadc233`+dirty	1266.52 ms	1282.55 ms	16.03 ms
`f06c879`+dirty	1285.14 ms	1285.86 ms	0.72 ms
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms

App size

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`4a6664f`+dirty	2.92 MiB	3.60 MiB	702.09 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`dadc233`+dirty	2.92 MiB	3.40 MiB	492.53 KiB
`f06c879`+dirty	2.92 MiB	3.44 MiB	533.24 KiB
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB

… lock

* Bumps cocoa from 8.29.1 to 8.36.0 * removed duplicate SentryTraceHeader definition * Update CHANGELOG.md * fix(metro): Fix sourceMapString is not a function, support [email protected] (see #4004) * misc: Update to RN 0.73.9, fix CI flipper error (see #3981) * use fixed version of react-native-gesture-handler --------- Co-authored-by: lucas <[email protected]>

misc: Update to RN 0.73.9, fix CI flipper error

a916601

krystofwoldrich requested a review from lucas-zimerman as a code owner July 30, 2024 15:05

krystofwoldrich added 2 commits July 30, 2024 17:25

enable corepack to allow yarn 3.x

86ef777

fix sample yarn lock

710057d

krystofwoldrich added 3 commits July 30, 2024 18:16

fix yarn install with version 3 and newer

b750cbe

only enable corepack for the latest RN version and allow mutable yarn…

5bb24d5

… lock

fix yarn v3 rc file

282afa5

vaind approved these changes Jul 31, 2024

View reviewed changes

vaind merged commit a4c376f into main Jul 31, 2024
61 of 62 checks passed

vaind deleted the kw/fix-ci-73-failing-flipper-ios branch July 31, 2024 06:25

antonis mentioned this pull request Sep 19, 2024

chore(deps): Hotfix: update Cocoa SDK from 8.29.1 to 8.36.0 #4102

Merged

antonis pushed a commit that referenced this pull request Sep 19, 2024

misc: Update to RN 0.73.9, fix CI flipper error (see #3981)

65f2b5b

antonis added a commit that referenced this pull request Sep 19, 2024

misc: Update to RN 0.73.9, fix CI flipper error (see #3981)

7d75153

antonis mentioned this pull request Oct 9, 2024

Chore: Upgrade sample and E2E tests to RN 0.75 #4155

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc: Update to RN 0.73.9, fix CI flipper error #3981

misc: Update to RN 0.73.9, fix CI flipper error #3981

krystofwoldrich commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jul 30, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jul 30, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jul 30, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

misc: Update to RN 0.73.9, fix CI flipper error #3981

misc: Update to RN 0.73.9, fix CI flipper error #3981

Conversation

krystofwoldrich commented Jul 30, 2024 • edited Loading

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

github-actions bot commented Jul 30, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jul 30, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jul 30, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jul 30, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading