Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Rails 7.x test suite #2433

Closed
wants to merge 3 commits into from
Closed

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Oct 17, 2024

Thanks for your Pull Request 🎉

Please keep these instructions in mind so we can review it more efficiently:

  • Add the references of all the related issues/PRs in the description
  • Whether it's a new feature or a bug fix, make sure they're covered by new test cases
  • If this PR contains any refactoring work, please give it its own commit(s)
  • Finally, please add an entry to the corresponding changelog

Other Notes

  • We squash all commits before merging
  • We generally review new PRs within a week
  • If you have any question, you can ask for feedback in our discord community first

Description

Describe your changes:

Copy link

github-actions bot commented Oct 17, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Slow Rails 7.x test suite ([#2433](https://github.com/getsentry/sentry-ruby/pull/2433))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 45395cb

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (d134d9e) to head (45395cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2433   +/-   ##
=======================================
  Coverage   98.70%   98.71%           
=======================================
  Files         221      221           
  Lines       14508    14536   +28     
=======================================
+ Hits        14320    14349   +29     
+ Misses        188      187    -1     
Components Coverage Δ
sentry-ruby 99.02% <ø> (+<0.01%) ⬆️
sentry-rails 97.47% <100.00%> (+0.03%) ⬆️
sentry-sidekiq 97.58% <ø> (ø)
sentry-resque 97.11% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/spec/dummy/test_rails_app/app.rb 94.84% <100.00%> (+2.09%) ⬆️

... and 1 file with indirect coverage changes

@solnic solnic force-pushed the solnic/slow-rails-spec-suite branch from 7c5b180 to c8df8cd Compare October 17, 2024 07:42
@solnic solnic force-pushed the solnic/slow-rails-spec-suite branch from 38096d3 to 75507fa Compare October 17, 2024 08:55
@solnic solnic closed this Oct 17, 2024
@solnic solnic deleted the solnic/slow-rails-spec-suite branch October 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant