feat(aci): Add helpers to dual write to Actions and DataConditions #82492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
reviewed
Dec 20, 2024
| @@ -30,9 +30,23 @@ class Action(DefaultFieldsModel): | |||
| __repr__ = sane_repr("id", "type") | |||
|
|
|||
| class Type(models.TextChoices): | |||
| EMAIL = "email" | |||
| SLACK = "slack" | |||
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #82492 +/- ##
==========================================
+ Coverage 79.40% 80.43% +1.03%
==========================================
Files 7313 7314 +1
Lines 322544 322644 +100
Branches 21039 21039
==========================================
+ Hits 256102 259516 +3414
+ Misses 66038 62724 -3314
Partials 404 404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd part of https://github.com/getsentry/sentry/pull/81953/files to dual write to the
ActionandDataConditionmodels when creatingAlertRuleTriggerandAlertRuleTriggerActionrows.