Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job-runner): move job manifest path #6517

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

onewland
Copy link
Contributor

@onewland onewland commented Nov 5, 2024

We found that we cannot rely on configmaps that mount as a specific file in k8s: they don't update without a restart (https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath)

Documentation about subpath

But, we cannot overwrite the contents of snuba/manual_jobs/ by mounting configuration there because we rely on source code in that directory. So we are moving this config to a new directory that doesn't pollute anything else (snuba/env).

Next step:

  • updating the mount in ops to point to snuba/env

@onewland onewland requested a review from a team as a code owner November 5, 2024 23:42
@onewland onewland merged commit 640beb4 into master Nov 6, 2024
30 checks passed
@onewland onewland deleted the move-manifest-location branch November 6, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants