Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flakey test for EndpointTraceItemAttributeNames #6523

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

kylemumma
Copy link
Member

@kylemumma kylemumma commented Nov 6, 2024

The bug:

I was querying for the attributes and they look something like this

a_tag_1
a_tag_2
...
a_tag_30
http.status
sentry.environment
...

The a_tag attributes I created and know where they're coming from. The others like http.status idk where they come from, and it turns out that they will be different on the local machine and in CI. I hard coded them to what they are on my local machine but they were different in CI sometimes which caused the tests to fail.

The way previous tests handled this was only validating the first 10

a_tag_1
...
a_tag_10

so they never encountered the changing attributes like http.status. But I didnt like this too much since its ignoring a lot of the other results (like 11 through 30).

I decided to solve the bug by validating only all the a_tag and allowing any arbitrary extra attributes

a_tag_1
...
a_tag_30

(so now http.status can be there, or not it doesnt matter)

@kylemumma kylemumma marked this pull request as ready for review November 6, 2024 20:19
@kylemumma kylemumma requested review from a team as code owners November 6, 2024 20:19
@kylemumma kylemumma merged commit 103a6d9 into master Nov 6, 2024
30 checks passed
@kylemumma kylemumma deleted the krm/fixtest branch November 6, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants