fix: flakey test for EndpointTraceItemAttributeNames #6523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug:
I was querying for the attributes and they look something like this
The
a_tag
attributes I created and know where they're coming from. The others likehttp.status
idk where they come from, and it turns out that they will be different on the local machine and in CI. I hard coded them to what they are on my local machine but they were different in CI sometimes which caused the tests to fail.The way previous tests handled this was only validating the first 10
so they never encountered the changing attributes like
http.status
. But I didnt like this too much since its ignoring a lot of the other results (like 11 through 30).I decided to solve the bug by validating only all the
a_tag
and allowing any arbitrary extra attributes(so now
http.status
can be there, or not it doesnt matter)