Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to python 3.12 (GSI-912) #25

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Update to python 3.12 (GSI-912) #25

merged 4 commits into from
Jul 22, 2024

Conversation

TheByronHimes
Copy link
Member

Contains the usual template updates plus:

  • Changes to silence some mypy errors
  • Uses the newer test fixtures.
  • Adds 'key' to the consumer function
  • @pytest.mark.asyncio(scope="session") was replaced with a module-level pytestmark=pytest.mark.asyncio in modules where all tests were async. In modules where there were some synchronous tests, only (scope="session") was removed
  • Gets rid of uses of Optional and Union and so on

Nothing was refactored or modified otherwise. Patch version number was bumped (2.0.0 -> 2.0.1)

@TheByronHimes
Bump version from 2.0.0 -> 2.0.1
5c9a05b 
Update template files

Transition test fixtures to split container-client model

Consolidate pytest asyncio markers where able and fix scope
@TheByronHimes
Silence mypy
9362051
@TheByronHimes
Be more specific with top-level dependencies
0c757a4
@coveralls
Copy link

coveralls commented Jul 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10010046174

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 90.417%
Files with Coverage Reduction New Missed Lines %
src/mass/main.py 1 0.0%
Totals Coverage Status
Change from base Build 7723410825: 0.08%
Covered Lines: 434
Relevant Lines: 480
💛 - Coveralls

mephenor
mephenor requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small issues

.pyproject_generation/pyproject_custom.toml Show resolved Hide resolved
.pyproject_generation/pyproject_custom.toml Outdated Show resolved Hide resolved
tests/fixtures/joint.py Show resolved Hide resolved
@TheByronHimes TheByronHimes merged commit da6dec1 into main Jul 22, 2024
9 checks passed
@TheByronHimes TheByronHimes deleted the update_to_python_3-12 branch July 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mephenor mephenor mephenor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheByronHimes @coveralls @mephenor