Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi valued facets (GSI-944) #29

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Support multi valued facets (GSI-944) #29

merged 9 commits into from
Aug 6, 2024

Conversation

Cito
Copy link
Member

@Cito Cito commented Aug 5, 2024

  • Support facet fields that hold multiple values
  • Separate test for different cases of filtering
  • Fix minor issue with newer setuptools version where author and email are combined

@Cito Cito requested a review from TheByronHimes August 5, 2024 15:17
@coveralls
Copy link

coveralls commented Aug 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10263255361

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 90.272%
Totals Coverage Status
Change from base Build 10246655250: 0.5%
Covered Lines: 464
Relevant Lines: 514
💛 - Coveralls

TheByronHimes
TheByronHimes previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's see how it goes with test bed.

src/mass/adapters/outbound/utils.py Outdated Show resolved Hide resolved
@TheByronHimes TheByronHimes self-requested a review August 6, 2024 08:46
@Cito Cito merged commit 9432e96 into main Aug 6, 2024
9 checks passed
@Cito Cito deleted the feature/multi-value-facets-GSI-944 branch August 6, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheByronHimes TheByronHimes TheByronHimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cito @coveralls @TheByronHimes