Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow facets in multi-valued objects and other improvements #30

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

Cito
Copy link
Member

@Cito Cito commented Aug 6, 2024

The PR contains these fixes and improvements:

  • allow facets in multi-valued objects and test this
    • currently only works when the field is directly inside that object
  • always return the facet options sorted by value
  • do not change the config in place when the ID is missing as selected field
    • this caused the response of search-options to change after the first query
  • replace dots with blanks when auto creating names from keys (so "study.title" becomes "Study Title" now)
  • more than double the test speed by reusing state

@Cito Cito requested a review from TheByronHimes August 6, 2024 15:46
@coveralls
Copy link

coveralls commented Aug 6, 2024

Pull Request Test Coverage Report for Build 10276236005

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 90.234%

Totals Coverage Status
Change from base Build 10263314868: -0.04%
Covered Lines: 462
Relevant Lines: 512

💛 - Coveralls

@Cito Cito changed the title Sort options and replace dots in keys Sort options, replace dots, do not modify config Aug 6, 2024
@Cito Cito changed the title Sort options, replace dots, do not modify config Allow facets in multi-valued objects and other improvements Aug 7, 2024
@TheByronHimes TheByronHimes self-requested a review August 7, 2024 07:17
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@Cito Cito merged commit f7864dc into main Aug 7, 2024
9 checks passed
@Cito Cito deleted the feature/minor-changes-to-options-and-names branch August 7, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants