Skip to content

Commit

Permalink
Do not install node js (#215)
Browse files Browse the repository at this point in the history
  • Loading branch information
Cito authored Jun 24, 2024
1 parent de0c95f commit 3bcdc6a
Show file tree
Hide file tree
Showing 9 changed files with 919 additions and 800 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ARG USER_GID=$USER_UID
RUN if [ "$USER_GID" != "1000" ] || [ "$USER_UID" != "1000" ]; then groupmod --gid $USER_GID vscode && usermod --uid $USER_UID --gid $USER_GID vscode; fi

# [Option] Install Node.js
ARG INSTALL_NODE="true"
ARG INSTALL_NODE="false"
ARG NODE_VERSION="lts/*"
RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi

Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ services:
dockerfile: ./Dockerfile
args:
# [Choice] Install Node.js
INSTALL_NODE: "true"
INSTALL_NODE: "false"
NODE_VERSION: "lts/*"
# Please adapt to package name:
PACKAGE_NAME: "my_microservice"
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ repos:
- id: no-commit-to-branch
args: [--branch, dev, --branch, int, --branch, main]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.4.4
rev: v0.4.10
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Expand Down
2 changes: 1 addition & 1 deletion .pyproject_generation/pyproject_custom.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies = [
"typer >= 0.12",
"ghga-service-commons[api] >= 3.1",
"ghga-event-schemas >= 3.3",
"hexkit[akafka,s3,mongodb] >= 3.1",
"hexkit[akafka,s3,mongodb] >= 3.2",
]

[project.urls]
Expand Down
4 changes: 2 additions & 2 deletions lock/requirements-dev-template.in
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# common requirements for development and testing of services

pytest>=8.2
pytest-asyncio>=0.23.6
pytest-asyncio>=0.23.7
pytest-cov>=5
snakeviz>=2.2
logot>=1.3
Expand Down Expand Up @@ -29,4 +29,4 @@ setuptools>=69.5
# required since switch to pyproject.toml and pip-tools
tomli_w>=1.0

uv>=0.1.44
uv>=0.2.13
2 changes: 1 addition & 1 deletion lock/requirements-dev.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
-r requirements-dev-template.in

# additional requirements can be listed here
testcontainers[kafka,mongo]>=4.4.1
testcontainers[kafka,mongo]>=4.6.0
919 changes: 472 additions & 447 deletions lock/requirements-dev.txt

Large diffs are not rendered by default.

784 changes: 439 additions & 345 deletions lock/requirements.txt

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies = [
"typer >= 0.12",
"ghga-service-commons[api] >= 3.1",
"ghga-event-schemas >= 3.3",
"hexkit[akafka,s3,mongodb] >= 3.1",
"hexkit[akafka,s3,mongodb] >= 3.2",
]

[project.license]
Expand Down

0 comments on commit 3bcdc6a

Please sign in to comment.