Skip to content

Commit

Permalink
Fix outdated requirements file refs (#192)
Browse files Browse the repository at this point in the history
* Update dev_install

* Fix a couple other missed refs

---------

Co-authored-by: TheByronHimes <[email protected]>
  • Loading branch information
TheByronHimes and TheByronHimes authored Dec 22, 2023
1 parent 51c0b13 commit cd9d89a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/dev_install
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ cd /workspace
python -m pip install --upgrade pip

# install or upgrade dependencies for development and testing
pip install --no-deps -r requirements-dev.txt
pip install --no-deps -r ./lock/requirements-dev.txt

# install the package itself in edit mode:
pip install --no-deps -e .
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN apt update
RUN apt upgrade -y
# copy and install requirements and wheel
WORKDIR /service
COPY --from=builder /service/requirements.txt /service
COPY --from=builder /service/lock/requirements.txt /service
RUN pip install --no-deps -r requirements.txt
RUN rm requirements.txt
COPY --from=builder /service/dist/ /service
Expand Down
7 changes: 4 additions & 3 deletions scripts/list_outdated_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@

REPO_ROOT_DIR = Path(__file__).parent.parent.resolve()
PYPROJECT_TOML_PATH = REPO_ROOT_DIR / "pyproject.toml"
DEV_DEPS_PATH = REPO_ROOT_DIR / "requirements-dev.in"
LOCK_FILE_PATH = REPO_ROOT_DIR / "requirements-dev.txt"
LOCK_DIR = REPO_ROOT_DIR / "lock"
DEV_DEPS_PATH = LOCK_DIR / "requirements-dev.in"
LOCK_FILE_PATH = LOCK_DIR / "requirements-dev.txt"


class OutdatedDep(NamedTuple):
Expand Down Expand Up @@ -78,7 +79,7 @@ def get_deps_dev() -> list[Requirement]:
for line in (line.strip() for line in dev_deps)
if line # skip empty lines
and not line.startswith("#") # skip comments
and "requirements-dev-common.in" not in line # skip inclusion line
and "requirements-dev-template.in" not in line # skip inclusion line
]

return [Requirement(dependency) for dependency in dependencies]
Expand Down

0 comments on commit cd9d89a

Please sign in to comment.