-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff (GSI-339) #161
Use ruff (GSI-339) #161
Conversation
Delete isort, pylint, flak8, and bandit from it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. As always, an outstanding PR description, that really helps and serves as a good documentation if later questions come up.
Thanks also for te prep-commit update scripts, that really handy in deed.
Just some cosmetics.
Use typer wrapper (cli.py)
Pull Request Test Coverage Report for Build 6274642022
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Sorry, could only do a superficial review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you still add comments to all entries in the "ignore" list?
🐶 Using ruff to replace some of our code quality tools.
Ruff is a python linter written in rust that runs much, much faster than pylint.
Ruff is not a drop-in replacement for pylint, but it implements several dozen of pylint's rules (see here for the list and here for a comparison)). Looking at the parity tracking, ruff seems to implement the most important rules from pylint.
It can, however, be used as a drop-in replacement for flake8.
Changes
update_lock.py
to.static_files
(was missed in previous PR)scripts/update_hook_revs.py
to keep the ruff/black/mypy pre-commit hook versions in line with the dependencies in the lock file. This is also added as a first-step pre-commit hook run with --check..ruff.toml
(thanks @Cito) to include flake8-bugbear, flake8-bandit, ruff's rules from pylint, isort, pyupgrade, and more.