Enable pydantic v2 (GSI 448) #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerstenBreuer
previously approved these changes
Oct 25, 2023
Cito
requested changes
Oct 25, 2023
Pull Request Test Coverage Report for Build 6640636772
💛 - Coveralls |
KerstenBreuer
approved these changes
Oct 25, 2023
Cito
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
update_config_docs.pyto attempt to importBaseSettingsfrom pydantic_settings. UponImportError, it will import the class from vanilla pydantic.As a side note, the readme's config parameter enumeration looks ugly now. Something must have changed with one of the underlying packages, so we should look into that.