Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy up root dir (GSI-540) #186

Merged
merged 9 commits into from
Dec 18, 2023
Merged

tidy up root dir (GSI-540) #186

merged 9 commits into from
Dec 18, 2023

Conversation

KerstenBreuer
Copy link
Contributor

@KerstenBreuer KerstenBreuer commented Dec 18, 2023 •
edited
Loading 

- move template file lists in dedicated directory
- move lock files and .in files into dedicated directory
- move files related to readme generation into dedicated directory

Let's maybe collect all the changes to the template in the refactor_root branch. And merge that branch once we are done so that all the changes hit relying services at once.

This PR (ghga-de/gh-action-common#8) needs to be merged first, for the actions to succeed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7250293338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.056%
Totals Coverage Status
Change from base Build 7249108103: 0.0%
Covered Lines: 31
Relevant Lines: 72
💛 - Coveralls

@KerstenBreuer KerstenBreuer changed the title Moved template file lists (GSI-540) tidy up root dir (GSI-540) Dec 18, 2023
TheByronHimes
TheByronHimes requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just a couple adjustments to make update_template_files work and it should be good to go

scripts/update_template_files.py Outdated Show resolved Hide resolved
scripts/license_checker.py Outdated Show resolved Hide resolved
@KerstenBreuer KerstenBreuer merged commit 19c6048 into refactor_root Dec 18, 2023
8 checks passed
@KerstenBreuer KerstenBreuer deleted the feature/tidy_upt_root_GSI-540 branch December 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheByronHimes TheByronHimes TheByronHimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KerstenBreuer @TheByronHimes