Enable default alpine and fallback debian docker image builds (GSI-876) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Byron Himes <[email protected]>
Co-authored-by: Byron Himes <[email protected]>
Pull Request Test Coverage Report for Build 10263934747Details
💛 - Coveralls |
Cito
previously approved these changes
Aug 5, 2024
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
lkuchenb
requested review from
TheByronHimes and
Cito
and removed request for
TheByronHimes
Cito
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the template such that it contains two Dockerfiles:
Dockerfilewhich builds a runner container based on python-alpineDockerfile.debianwhich builds a runner container based on python-debianBoth images are pushed to Dockerhub, once with the tag suffix
-debianonce without (this makes use of the recently added support for "flavors" in PR ghga-de/gh-action-ci#4).The alpine Dockerfile has been tested on all currently deployed services to the extend that they start and fail due to missing configuration.
A separate PR will be opened at https://github.com/ghga-de/file-services-backend.