Configurable SMTP Timeout (GSI-986)

[TheByronHimes]

Adds an optional smtp_timeout config option. By default it will maintain the prior infini-hang behaviour time out after 60 seconds. Added an error class to the SMTPClient to catch any instance of OSError raised by a rejected connection or timeout.

Added in some debug statements in the SMTP module to aid in future bug hunting.

Bumped the version from 2.0.0 to 2.1.0.

[mephenor]

Looks good, just one suggestion

[dontseyit]

Why the default is None? I would expect, as a default behavior, an error message eventually if there is a problem in connection rather than infinite waiting. Then adjusting the value accordingly if necessary. So I would say 60 seconds.

[coveralls]

Pull Request Test Coverage Report for Build 10737100864

Details

• 20 of 21 (95.24%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.9%) to 85.874%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/ns/adapters/outbound/smtp_client.py	14	15	93.33%

Totals
Change from base Build 10594708067:	0.9%
Covered Lines:	231
Relevant Lines:	269

---

💛 - Coveralls

[dontseyit]

Looks good to me now, thanks.